Skip to content

OCPBUGS-59626: operator/v1helpers: add namespaced secret/configmap getters #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

OCPBUGS-59626: operator/v1helpers: add namespaced secret/configmap getters #2007

wants to merge 2 commits into from

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Sep 2, 2025

Create new getters similar to CachedConfigMapGetter/CachedSecretGetter, but without a dependency on
a cluster-level informer. This allows the operator to continue functioning when etcd has a corrupted
key outside of target namespace. These new getters fall back to live client calls when a different
namespace is being requested.

Tested in openshift/cluster-kube-apiserver-operator#1916

@vrutkovs
operator/v1helpers: add namespaced secret/configmap getters
8593a90 
Create new getters similar to CachedConfigMapGetter/CachedSecretGetter, but without a dependency on
a cluster-level informer. This allows the operator to continue functioning when etcd has a corrupted
key outside of target namespace. These new getters fall back to live client calls when a different
namespace is being requested
@vrutkovs
operator/staticpod: use namespaced getters
75e3b7d 
Ensure that corruption of cluster-level cache doesn't affect static pod rollout
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 2, 2025
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-59626, which is invalid:

  • expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.20" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Create new getters similar to CachedConfigMapGetter/CachedSecretGetter, but without a dependency on
a cluster-level informer. This allows the operator to continue functioning when etcd has a corrupted
key outside of target namespace. These new getters fall back to live client calls when a different
namespace is being requested.

Tested in openshift/cluster-kube-apiserver-operator#1916

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jsafrane and tkashem September 2, 2025 11:49
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 2, 2025

@vrutkovs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Member Author

vrutkovs commented Sep 2, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 2, 2025
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-59626, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gangwgr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from gangwgr September 2, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@tkashem tkashem Awaiting requested review from tkashem

@gangwgr gangwgr Awaiting requested review from gangwgr

Assignees

No one assigned

Labels

jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vrutkovs @openshift-ci-robot